Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide cost and usage in playground and evaluation when these are not specified #1607

Merged
merged 9 commits into from
May 13, 2024
Merged

Hide cost and usage in playground and evaluation when these are not specified #1607

merged 9 commits into from
May 13, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented May 3, 2024 •
edited
Loading

Closes #1584

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 3, 2024
@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 0:33am

@bekossy bekossy requested a review from aakrem May 3, 2024 11:30
@bekossy
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
dff89e0 
…d-and-evaluation-when-these-are-not-specified
@bekossy
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
76a5625 
…d-and-evaluation-when-these-are-not-specified
@dosubot dosubot bot added this to the v.44 milestone May 5, 2024
@aakrem
Copy link
Collaborator

aakrem commented May 6, 2024 •
edited
Loading

I added a small comment in the issue itself. maybe we need to fix this in backend
#1584 (comment)

@bekossy
Merge branch 'main' into issue-1584/-hide-cost-and-usage-in-playgroun…
55e475b 
…d-and-evaluation-when-these-are-not-specified
aakrem
aakrem requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy
Please have a look at the comments here :

#1584

@bekossy bekossy requested a review from aakrem May 8, 2024 12:57
aakrem
aakrem requested changes May 8, 2024
View reviewed changes
agenta-web/src/lib/helpers/formatters.ts Outdated Show resolved Hide resolved
@bekossy bekossy requested a review from aakrem May 9, 2024 01:42
aakrem
aakrem requested changes May 9, 2024
View reviewed changes
agenta-web/src/lib/helpers/formatters.ts Show resolved Hide resolved
agenta-web/src/lib/helpers/formatters.ts Outdated Show resolved Hide resolved
@bekossy bekossy requested a review from aakrem May 13, 2024 00:31
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2024
@aakrem aakrem merged commit e426e4d into main May 13, 2024
8 checks passed
@aakrem aakrem deleted the issue-1584/-hide-cost-and-usage-in-playground-and-evaluation-when-these-are-not-specified branch May 13, 2024 05:16
@aakrem
Copy link
Collaborator

aakrem commented May 13, 2024

thanks @bekossy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. typescript UI
Projects
None yet
Milestone
v.44
Development

Successfully merging this pull request may close these issues.

[AGE-160] Hide cost and usage in playground and evaluation when these are not specified
2 participants
@bekossy @aakrem